-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: highlight environment on string containing dot #5409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: highlight environment on string containing dot #5409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes environment variable highlighting to support dots in variable names, addressing issue #5336. It enables namespaced variable patterns like <<api.v1.key>> by updating the regex pattern and extracting it to a reusable constant.
- Updated environment variable regex pattern to include dots for namespaced variables
- Extracted the pattern to a common constant
ENV_VAR_NAME_PATTERNfor better maintainability - Updated cursor tooltip field logic to use the new pattern consistently
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1ca8ef5 to
218bdc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This PR closes #5336
What's changed