Add a test that stream actions rendered into the HTML are executed#1263
Merged
brunoprietog merged 1 commit intohotwired:mainfrom Jan 8, 2025
Merged
Conversation
This was referenced May 24, 2024
As a consequence of the fundamental way in which Stream actions are implemented, they can also be executed by rendering them within any HTML that's included on the dom. Since this is already being used as the feature in the community, adding this test will ensure this keeps working.
f25d5cd to
8dfce21
Compare
brunoprietog
approved these changes
Jan 8, 2025
Collaborator
brunoprietog
left a comment
There was a problem hiding this comment.
Thanks @radanskoric!
Contributor
Author
|
Thank you @brunoprietog! What do you think are the chances of the matching documentation update being merged? |
Collaborator
|
Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #1258
It's paired with: hotwired/turbo-site#192
As a consequence of the fundamental way in which Stream actions are implemented, they can also be executed by rendering them within any HTML that's included on the dom.
Since this is already being used as the feature in the community, adding this test will ensure this keeps working.