Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed random timeout issues causing the whole program to hang until r… #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hrkfdn merged 7 commits into from
Apr 30, 2016
Merged

Fixed random timeout issues causing the whole program to hang until r… #33

hrkfdn merged 7 commits into from
Apr 30, 2016

Conversation

@TheReverend403
Copy link
Contributor

@TheReverend403 TheReverend403 commented Apr 28, 2016

…estart.

Don't ignore curl dude, it has some quite useful error information :)

@TheReverend403
Copy link
Contributor Author

TheReverend403 commented Apr 28, 2016

Works quite well from my small amount of testing.

Apr 28 22:35:41 serenity mpdas[17940]: (22:35:41) [INFO] New song: Trivium - The Thing That’s Killing Me
Apr 28 22:35:41 serenity mpdas[17940]: (22:35:41) [INFO] Updated "Now Playing" status successfully.
Apr 28 22:36:49 serenity mpdas[17940]: (22:36:49) [INFO] New song: Trivium - Beneath the Sun
Apr 28 22:36:49 serenity mpdas[17940]: (22:36:49) [INFO] Updated "Now Playing" status successfully.
Apr 28 22:46:03 serenity mpdas[17940]: (22:46:03) [INFO] New song: Trivium - Breathe in the Flames
Apr 28 22:46:13 serenity mpdas[17940]: (22:46:13) [ERROR] libcurl: (28)
Apr 28 22:46:13 serenity mpdas[17940]: (22:46:13) [ERROR] Timeout was reached
Apr 28 22:46:13 serenity mpdas[17940]: (22:46:13) [ERROR] Will retry 3 times with a 3 second delay.
Apr 28 22:46:16 serenity mpdas[17940]: (22:46:16) [ERROR] Retry 1/3
Apr 28 22:46:17 serenity mpdas[17940]: (22:46:17) [INFO] Updated "Now Playing" status successfully.

@hrkfdn
Copy link
Owner

hrkfdn commented Apr 30, 2016 •
edited
Loading

Well well, I certainly didn't mean to ignore what cURL has to say. It's just that back then we didn't know each other very well ;) Also it seems I have never encountered a timeout.

I have merged this locally and am testing this. Will push it upstream soon, I think. Thanks!

@hrkfdn hrkfdn merged commit c8cd969 into hrkfdn:master Apr 30, 2016
hrkfdn added a commit that referenced this pull request Apr 30, 2016
@hrkfdn
Merge branch 'TheReverend403-patch-1'
cd6fadf 
closes #33
@TheReverend403
Copy link
Contributor Author

TheReverend403 commented Apr 30, 2016 •
edited
Loading

Yeah, a lot of people I spoke to on IRC said the same thing, and the people that were affected by this issue in mpdas also had the exact same problem with mpdscribble, so I'm wondering if it's an account-based issue. The way I always got it to happen was starting a song, leaving it in a paused state for about 15 minutes, then playing a new song.

Anyway, thanks for merging :)

@TheReverend403 TheReverend403 deleted the patch-1 branch April 30, 2016 11:18
@vojislav vojislav mentioned this pull request Mar 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheReverend403 @hrkfdn