Fix crash when shift amount is greater than queue length #1706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note this preserves behaviour of shifting by negative numbers in either direction changelog also updated accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removed the cast to an
i32, then back to ausizeas it caused an unintentional integer overflow when subtracting. Instead,amountis cast as ausize.As this breaks negative number inputs, these are first checked for, and the
ShiftModeflipped accordingly. The amount value is then set to its absolute value, ensuring correct behaviour regardless.Issue ticket number and link
Checklist before requesting a review
not performance improvements, etc.)