use interpolation to smoothly scale acceleration#226
Merged
hrvach merged 1 commit intohrvach:mainfrom Mar 9, 2025
Merged
Conversation
Owner
|
Floating point is usually slow on rp2040, but the difference shouldn't be that significant. I might try an alpha max + beta min approach just out of curiosity. |
Owner
|
@rygwdn tried to accelerate the float operations a bit, can you test if this change still works as you expect? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current->speed_{x,y}values which are typically greater than 1 and so this retains the fractional acceleration factors further through the calculations. i.e. if speed_x is 10, then previously then the acceleration curve could only adjust the movement by a multiple of 10, now it can always adjust down to 1.