Achievement Unlocked sound effect, more UI work #17705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
763d589 to
943bfb7
Compare
34 tasks
| loginButton->OnClick.Add([=](UI::EventParams &) -> UI::EventReturn { | ||
| if (!username_.empty() && !password_.empty()) { | ||
| Achievements::LoginAsync(username_.c_str(), password_.c_str()); | ||
| password_.clear(); |
There was a problem hiding this comment.
I suppose, ideally, should memset() to zero first before clear(). Though, we're not even using SSL yet so probably that's overthinking things.
-[Unknown]
There was a problem hiding this comment.
Though, why not. I'll do it. There'll probably be more copies of the string floating around in memory though from the inputbox..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now plays a sound when you:
Will be made customizable later.
Part of #17631