Custom achievement sound effects #17725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 tasks
|
I wonder if it's worth implementing copying the files like we do with background images.. |
|
That's probably more expected behavior these days. Plus we could copy it to internal storage which might be faster to load. (we should probably even move the background image to internal storage I guess, but BC...) -[Unknown] |
|
Yeah, I kinda forgot about the copy thing when implementing this, otherwise I would have done that directly.. It is indeed probably expected. And yeah, might as well do internal storage for these at least... I'll get around to it one of these days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement achievement sound effect customization (which could be easily be extended to support customizing the other sound effects too). Currently we only have two sound effects, achievement unlocked and submit score to leaderboard.
Needs a bit of testing before merge, and removal of the choice if the platform doesn't have file selector dialogs...Part of #17631