Remove ffmpeg use from the sceAtrac HLE module #19053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2024
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of ffmpeg from
sceAtrac, instead we now use the standalone decoders I extracted from ffmpeg in #19033.These standalone decoders are easier to deal with - as you can see the code gets simpler - and we'll even be able to save their state later which may reduce minor glitches on savestate load (in theory, at least), which wasn't really possible with ffmpeg.
This should not affect compatibility in any way if I did it right (also, savestates still work) - Flatout is still not working correctly. However, this makes debugging this stuff a bit easier, at least.
@unknownbrackets FYI