web: add support of internatialization (#11) #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstlepa
requested changes
Nov 18, 2020
| return err | ||
| } | ||
|
|
||
| func isOldStyleUserTemplate(root *template.Template) bool { |
There was a problem hiding this comment.
Mention the issue that causes the creation of this function.
| return errors.Wrapf(err, "failed to parse template %q: %s", name, err) | ||
| } | ||
|
|
||
| if isOldStyleUserTemplate(root) { |
There was a problem hiding this comment.
Mention that this code will be deprecated in the future major release.
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 73.46% 72.77% -0.69%
==========================================
Files 8 8
Lines 539 518 -21
==========================================
- Hits 396 377 -19
+ Misses 112 107 -5
- Partials 31 34 +3
Continue to review full report at Codecov.
|
konstlepa
requested changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The PR adds support for the internationalization of the login page.