Bumped PHP CS Fixer to v3.89.1 and updated deprecated rules #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rule "braces" is deprecated. Use "single_space_around_construct", "control_structure_braces", "control_structure_continuation_position", "declare_parentheses", "no_multiple_statements_per_line", "braces_position", "statement_indentation" and "no_extra_blank_lines" instead. - Rule "native_function_type_declaration_casing" is deprecated. Use "native_type_declaration_casing" instead. - Rule "new_with_braces" is deprecated. Use "new_with_parentheses" instead. - Rule "no_unneeded_curly_braces" is deprecated. Use "no_unneeded_braces" instead.
d55fce7 to
def867a
Compare
Steveb-p
approved these changes
Oct 23, 2025
konradoboza
approved these changes
Oct 23, 2025
@konradoboza yeah, I'd like that too, but it's a bit difficult ATM, because of removal of FQCNs from the doc and multiline parameters. Applying 2.2.x-dev on Maybe I'll try to cherry-pick this to 2.1.0 tag locally... :/ |
Didn't aim to suggest any additional work. We can iterate and decide once we start using bumped version. |
alongosz
added a commit
to ibexa/admin-ui
that referenced
this pull request
Oct 23, 2025
alongosz
added a commit
to ibexa/admin-ui
that referenced
this pull request
Oct 23, 2025
alongosz
added a commit
to ibexa/core
that referenced
this pull request
Oct 24, 2025
alongosz
added a commit
to ibexa/core
that referenced
this pull request
Oct 24, 2025
This was referenced Oct 24, 2025
alongosz
added a commit
to ibexa/admin-ui
that referenced
this pull request
Oct 26, 2025
alongosz
added a commit
to ibexa/admin-ui
that referenced
this pull request
Oct 26, 2025
alongosz
added a commit
to ibexa/admin-ui
that referenced
this pull request
Oct 27, 2025
* The rule is configured in the `AbstractIbexaRuleSet`
`single_line_empty_body` tends to conflict with `braces_position` on some environments
…extra_blank_lines` `blank_line_between_import_groups` tends to conflict with `no_extra_blank_lines` on some environments
ab38329 to
3af3fa9
Compare
|
alongosz
added a commit
to ibexa/admin-ui
that referenced
this pull request
Oct 27, 2025
Files changed: 1) src/lib/Tab/Dashboard/PagerLocationToDataMapper.php (fully_qualified_strict_types, ordered_imports) 2) tests/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolverTest.php (fully_qualified_strict_types) 3) tests/lib/Form/DataTransformer/LanguageTransformerTest.php (fully_qualified_strict_types) 4) tests/lib/Form/Data/FormMapper/ContentTypeDraftMapperTest.php (fully_qualified_strict_types, header_comment, blank_lines_before_namespace) 5) tests/lib/Permission/LimitationResolverTest.php (fully_qualified_strict_types)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Yet another pre-release step for 2.2.0.
Bumped PHP CS Fixer fixed version constraint to the latest
v3.89.1.We had some deprecated rules. New fixer introduced
@PER-CS2x0set in place of@PER-CS2.0one.Also there were some pre-existing deprecations for
v3.75.0:It was quite complicated for thebraces, so hopefully I got it right.Seems like some rules conflict with each other:
braces_positionandsingle_line_empty_body. The former one creates:blank_line_between_import_groupsandno_extra_blank_lines. The former one:Defined explicitly in an ordered fashion (the last one seems to take precedence) for Ibexa 4.6 Rule Set. Ibexa 5.0 Rule Set relies on
@PER-CS2x0which sets these by default (experimented last week on admin-ui changes formainand it seemed not to produce any CS issues).Tip
Note that the above are non-deterministic and depend on some factors unknown to me. ATM CI was not showing these issues, however locally without defining explicit order for these rules, I got CS issues reported.