IBX-4929: Fix PhpDoc #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tag "since" with body "@SInCE v0.9.3" has error
6 tasks
adriendupuis
commented
Apr 5, 2023
|
|
||
| /** | ||
| * @since v0.9.3 | ||
| * @since 1.13 eZ Platform 1.13 (ezplatform-http-cache 0.9.3) |
There was a problem hiding this comment.
- eZ Platform 1.13.5
"ezsystems/ezplatform-http-cache": "~0.9.1", - eZ Platform 1.13.6
"ezsystems/ezplatform-http-cache": "~0.9.4",
It seems useless to be more precise
Suggested change
| * @since 1.13 eZ Platform 1.13 (ezplatform-http-cache 0.9.3) | |
| * @since 1.13.6 eZ Platform 1.13.6 (ezplatform-http-cache 0.9.3) |
There was a problem hiding this comment.
Tbh, I do not see value in that doc at all and we do not use it in other places - so from my pov, we could and should drop it.
@ibexa/php-dev
There was a problem hiding this comment.
+1 to Dawid's suggestion.
There was a problem hiding this comment.
@ViniTou @konradoboza
✅ Simple removal
|
Kudos, SonarCloud Quality Gate passed!
|
konradoboza
approved these changes
Apr 18, 2023
ViniTou
approved these changes
Apr 18, 2023
adamwojs
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag "since" with body "@since v0.9.3" has errorFix@sinceusage (see IBX-4929: Fixed PhpDoc in various places core#226 for more)TODO:
$ composer test)$ composer fix-cs).