[Symfony 7] Skipped SimplifyFormRenderingRector #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29ad63a to
571340a
Compare
ViniTou
approved these changes
Sep 4, 2025
tbialcz
approved these changes
Sep 4, 2025
konradoboza
approved these changes
Sep 4, 2025
adamwojs
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
While Symfony 6 suggested skipping calls to
$form->createView()and pass directly$formobject to a template, Symfony 7 reverted that statement due to some edge cases.However,
SimplifyFormRenderingRectorrule still exists in our configs (coming from general Symfony 6.2 set), because we apply all sets for Symfony 5 to 7. We need to, because we're jumping directly from SF 5 (Ibexa 4.6) to SF 7 (Ibexa 5.0).Seems adding
skipis the simplest workaround.