IBX-10859: Fixed ENCODER_CONTEXT being present in response for nested objects
#203
+90
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20ffff7 to
8f3bdb2
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where ENCODER_CONTEXT metadata was leaking into API responses when using the Visitor Adapter pattern. The fix recursively removes all ENCODER_CONTEXT entries from normalized data structures, including nested objects.
Key Changes:
- Added recursive
removeEncodeContext()method to stripENCODER_CONTEXTfrom all levels of data structures - Enhanced test coverage to verify removal of nested
ENCODER_CONTEXTentries
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/contracts/Output/Visitor.php | Implements recursive removal of ENCODER_CONTEXT from normalized data |
| tests/lib/Output/VisitorTest.php | Adds test coverage for nested ENCODER_CONTEXT removal with array and ArrayObject cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
barw4
approved these changes
Oct 27, 2025
ciastektk
approved these changes
Oct 27, 2025
konradoboza
approved these changes
Oct 27, 2025
tbialcz
approved these changes
Oct 27, 2025
ENCODER_CONTEXT being present in response for nested objectsENCODER_CONTEXT being present in response for nested objects
alongosz
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes
ENCODER_CONTEXTfrom responses, when using Visitor Adapter.For QA:
Documentation: