feat(hl): Add new FzfLuaPreviewBorder highlight#778
Closed
mikesmithgh wants to merge 1 commit intoibhagwan:mainfrom
Closed
feat(hl): Add new FzfLuaPreviewBorder highlight#778mikesmithgh wants to merge 1 commit intoibhagwan:mainfrom
mikesmithgh wants to merge 1 commit intoibhagwan:mainfrom
Conversation
Owner
|
Merged, tysm for the contribution @mikesmithgh! |
Contributor
|
I tried |
ibhagwan
added a commit
that referenced
this pull request
Jun 11, 2023
Owner
ibhagwan
added a commit
that referenced
this pull request
Jun 11, 2023
Owner
Contributor
|
@ibhagwan Now it works. I just tested the same command and the color can be changed dynamically :) Thank you! |
Contributor
|
@ibhagwan I found that the same problem occurs on
|
Owner
|
@nyngwang, there is no |
Contributor
|
You're right. I just realized that it is my custom highlight group for the titles of |
Contributor
Contributor
|
Confirmed, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to add an additional highlight group
FzfLuaPreviewBorder. I have different background colors for the fzf window and preview window. This allows me to customize the border on each differently to match the corresponding background color.Without the highlight group:

With the highlight group:

Please let me know what you think.