Fix potential infinite loop in mix_source_buffer() in case of uneven input buffer#31
Merged
icculus merged 1 commit intoicculus:mainfrom Jan 11, 2025
Merged
Conversation
This fixes a potential infinite loop, which may occur in two cases: 1. If remaining data in the input is less than `bufferframesize`, in such case `bytesput` resulted in 0, and src->offset never advanced. 2. If remaining data's size is not evenly divided by sizeof(float), the data pointer again will not advance to the end.
51aa56c to
afb81c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #23
This is a hotfix that we've been using in our game engine for a while now, it covers a rare situation with badly formed input buffer, which I've described in the issue #23.
This fixes a potential infinite loop, which may occur in two cases:
bufferframesize, in such casebytesputresulted in 0, and src->offset never advanced.