Serialize Rust enums as integers #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This finally removes the last `HashMap` usage in the code so we can remove `hashbrown` as a dependency if `no_std + serde`.
fengjixuchui
added a commit
to fengjixuchui/iced
that referenced
this pull request
Dec 18, 2022
Merge pull request icedland#372 from icedland/remove_hashbrown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally removes the last
HashMapusage in the code so we can removehashbrownas a dependency ifno_std + serde.json (de)serialization is now faster (but still slow compared to eg. bincode).
Serializing them as integers instead of strings isn't a problem. The same version of iced must be used to serialize and deserialize anything, and it's documented in the README.