Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vmcj
Copy link
Collaborator

@vmcj vmcj commented Aug 21, 2025

As discussed in Slack the next release will have Java17 as minimal. This upgrades the build to also build as Java17 which was already what the CI was using.

I also added some cleanup of the file, I choose multiple commits as I'm not that experienced with ant so those might be unneeded (or worse).

Old build extract:

build:
    [mkdir] Created dir: /srv/git/hub/icpctools/ProblemSet/bin
     [copy] Copying 3 files to /srv/git/hub/icpctools/ProblemSet/bin
    [javac] Compiling 5 source files to /srv/git/hub/icpctools/ProblemSet/bin
    [javac] warning: [options] system modules path not set in conjunction with -source 9
    [javac] 1 warning

version:

jar:
      [jar] Building jar: /srv/git/hub/icpctools/ProblemSet/staging/problemset.jar

doc:
     [exec] 1 - /srv/git/hub/icpctools/ProblemSet
     [exec] 2

dist:
      [zip] Building zip: /srv/git/hub/icpctools/dist/problemset-2.6.1250.zip

New:

build:
    [mkdir] Created dir: /srv/git/hub/icpctools/ProblemSet/bin
     [copy] Copying 3 files to /srv/git/hub/icpctools/ProblemSet/bin
    [javac] Compiling 5 source files to /srv/git/hub/icpctools/ProblemSet/bin

version:

jar:
      [jar] Building jar: /srv/git/hub/icpctools/ProblemSet/staging/problemset.jar

doc:
     [exec] 1 - /srv/git/hub/icpctools/ProblemSet
     [exec] 2

dist:
      [zip] Building zip: /srv/git/hub/icpctools/dist/problemset-2.6.1256.zip

BUILD SUCCESSFUL
Total time: 37 seconds

vmcj added 6 commits August 21, 2025 20:02
As discussed in Slack the next release will have Java17 as minimal. This
upgrades the build to also build as Java17 which was already what the CI
was using.
The CDS targetted Java9 but as Java17 is enough of an upgrade those can
now use the same version again.
We could leave this but it seems to do the same thing as the rest and
can be added again when cleaning should be done in a different way.
Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an ant expert either and hard to follow all the impacts... but we can always back out if we really needed to and the release change is necessary. Merging.

@deboer-tim deboer-tim merged commit 1af9b88 into icpctools:main Aug 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants