Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add more checks for public inputs #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add more checks for public inputs #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/fflonk_verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/

import * as curves from "./curves.js";
import { isBigIntArray } from "./misc.js";
import { BigBuffer, utils } from "ffjavascript";
import { Proof } from "./proof.js";
import { Keccak256Transcript } from "./Keccak256Transcript.js";
Expand All @@ -42,8 +43,8 @@ export default async function fflonkVerify(_vk_verifier, _publicSignals, _proof,

const publicSignals = unstringifyBigInts(_publicSignals);

if (publicSignals.length !== vk.nPublic) {
logger.error("Number of public signals does not match with vk");
if (!isBigIntArray(publicSignals, vk.nPublic)) {
logger.error("Public signals are not valid.");
return false;
}

Expand Down
4 changes: 3 additions & 1 deletion src/groth16_verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
/* Implementation of this paper: https://eprint.iacr.org/2016/260.pdf */
import { Scalar } from "ffjavascript";
import * as curves from "./curves.js";
import { isBigIntArray } from "./misc.js";
import { utils } from "ffjavascript";
const {unstringifyBigInts} = utils;

Expand All @@ -41,7 +42,8 @@ export default async function groth16Verify(_vk_verifier, _publicSignals, _proof
const IC = new Uint8Array(curve.G1.F.n8*2 * publicSignals.length);
const w = new Uint8Array(curve.Fr.n8 * publicSignals.length);

if (!publicInputsAreValid(curve, publicSignals)) {
if (!isBigIntArray(publicSignals, vk_verifier.nPublic) ||
!publicInputsAreValid(curve, publicSignals)) {
if (logger) logger.error("Public inputs are not valid.");
return false;
}
Expand Down
7 changes: 7 additions & 0 deletions src/misc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,3 +259,10 @@ export function stringifyBigIntsWithField(Fr, o) {
return o;
}
}

export function isBigIntArray(o, n) {
if (!Array.isArray(o) || o.length !== n) {
return false
}
return o.every(e => typeof e === "bigint")
}
9 changes: 3 additions & 6 deletions src/plonk_verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
/* Implementation of this paper: https://eprint.iacr.org/2019/953.pdf */

import * as curves from "./curves.js";
import { isBigIntArray } from "./misc.js";
import { utils } from "ffjavascript";
import { Keccak256Transcript } from "./Keccak256Transcript.js";
import { Scalar } from "ffjavascript";
Expand All @@ -46,17 +47,13 @@ export default async function plonkVerify(_vk_verifier, _publicSignals, _proof,
return false;
}

if (publicSignals.length != vk_verifier.nPublic) {
if (logger) logger.error("Invalid number of public inputs");
return false;
}

if (!evaluationsAreValid(curve, proof)) {
if (logger) logger.error("Proof evaluations are not valid");
return false;
}

if (!publicInputsAreValid(curve, publicSignals)) {
if (!isBigIntArray(publicSignals, vk_verifier.nPublic) ||
!publicInputsAreValid(curve, publicSignals)) {
if (logger) logger.error("Public inputs are not valid.");
return false;
}
Expand Down