fix: set charset for text/plain responses #9120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use settings.DEFAULT_CHARSET
ALL THE PLACES
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9120 +/- ##
==========================================
- Coverage 88.74% 88.73% -0.02%
==========================================
Files 321 320 -1
Lines 41853 41656 -197
==========================================
- Hits 37144 36962 -182
+ Misses 4709 4694 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
rjsparks
previously approved these changes
Jul 24, 2025
# Conflicts: # ietf/api/views.py
rjsparks
approved these changes
Jul 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes an observed bug with the iesg agenda_package.txt view, along with similar iesg views, by setting charset for the content type.
The second commit adjusts every place where we return an HTTP response with
content_type="text/plain"to set the charset as well. Most of these could be left alone - the default is US-ASCII, and most of them are simple fixed US-ASCII strings - but it seemed reasonable to me to speak utf-8 everywhere.Django will apply the encoding specified in the content_type to strings when it builds its response, so unless we're handling responses that include non-UTF-8 bytes or strings encoding characters UTF-8 can't represent, this should be safe. I didn't notice any of those, but it'd be good to check that.
Fixes #8968