feat: add auto-generated IPR email notifications on WG Call for Adoption or WG Last Call #9322

nouralmaa · 2025-08-07T17:32:21Z

…l for Adoption or WG Last Call

jennifer-richards · 2025-08-07T20:41:25Z

Thank you for cleaning up the PR!

evyncke · 2025-08-08T05:09:14Z

ietf/doc/mails.py

+def email_stream_state_changed_cfa(request, doc, cfa_duration=2):
+    (to, cc)= gather_address_lists('doc_stream_state_edited', doc=doc)
+
+    end_date= date_today(DEADLINE_TZINFO) + datetime.timedelta(days=14)


Should probably be days=7*cfa_duration

Thanks - committed

evyncke · 2025-08-08T05:09:56Z

ietf/doc/mails.py

+def email_stream_state_changed_wglc(request, doc, wglc_duration=2):
+    (to, cc)= gather_address_lists('doc_stream_state_edited', doc=doc)
+
+    end_date= date_today(DEADLINE_TZINFO) + datetime.timedelta(days=14)


Should probably be days = 7 * wglc_duration

Thanks - committed

…iews

rjsparks

A couple of quick observations - I haven't reviewed the changes to the tests yet.

rjsparks · 2025-08-11T14:51:45Z

ietf/doc/mails.py

              cc=cc)
+
+def email_stream_state_changed_cfa(request, doc, cfa_duration=2):
+    (to, cc)= gather_address_lists('doc_stream_state_edited', doc=doc)


This doesn't reach the recipients requested in the #9142 - it likely needs its own mailtrigger (see https://datatracker.ietf.org/mailtrigger/name/doc_stream_state_edited/ and https://datatracker.ietf.org/mailtrigger/name/).
Adding those will require a migration - let us know if you're already familiar with django migrations - if not, we can add them.

Added a new mailtrigger with the correct recipients, soz for not spotting that. The migration ran OK in my container - however since test settings disable migrations I re-edited tests_draft back to its original state to avoid migration-related errors. Let me know if you recommend testing or running the migration via another method.

rjsparks · 2025-08-11T14:52:13Z

ietf/doc/views_draft.py

+             # ipr notifs on cfa wglc 
+            if new_state.slug == "c-adopt":
+                email_stream_state_changed_cfa(request, doc)
+
+            if new_state.slug == "wg-lc":
+                email_stream_state_changed_wglc(request, doc)
+


This should be inside the if statement at L1752

Committed, thanks

rjsparks · 2025-08-11T14:52:42Z

ietf/doc/mails.py

+                cc=cc)
+
+def email_stream_state_changed_wglc(request, doc, wglc_duration=2):
+    (to, cc)= gather_address_lists('doc_stream_state_edited', doc=doc)


See the comment on L108 - this will also need a new mailtrigger.

Committed change with new mailtrigger

… wg-ipr-notifs

rjsparks · 2025-08-15T14:22:45Z

Datatracker's test harness is custom and one of the things it does for performance reasons is to use a fixture and some factories (and occasionally a utility function for meeting test data that we're trying to deprecate). These new mailtriggers should get added to the fixture.

After you've run the migrations in your local database run this:

ietf/manage.py generate_name_fixture --stdout | jq --sort-keys 'sort_by(.model, .pk)' > ietf/name/fixtures/names.json

It might pick up some unrelated changes - don't worry if it does.
Then the new names will be available to the tests.

Thanks for sticking with this - we're very happy to have the help. But if this kind of arcana becomes too much, let us know and we can finish out the PR.

nouralmaa · 2025-08-16T09:27:25Z

Datatracker's test harness is custom and one of the things it does for performance reasons is to use a fixture and some factories (and occasionally a utility function for meeting test data that we're trying to deprecate). These new mailtriggers should get added to the fixture.

After you've run the migrations in your local database run this:
ietf/manage.py generate_name_fixture --stdout | jq --sort-keys 'sort_by(.model, .pk)' > ietf/name/fixtures/names.json
It might pick up some unrelated changes - don't worry if it does. Then the new names will be available to the tests.

Thanks for sticking with this - we're very happy to have the help. But if this kind of arcana becomes too much, let us know and we can finish out the PR.

Have added the new fixture and tests for the CFA state, which should hopefully work alongside the existing stream state edited mailtrigger. WGLC isn't strictly tested but is in compatible format with the former. I tried to make everything as consistent as possible with the existing IETF repo. Feel free to finish out the PR with any additional edits. Thank you to everyone for the comments and guidance!

The two actions have the same recipients to start with, but that may change over time. Mailtrigger names should describe "what happened to trigger this email?". Changed the utility names to match the actions.

Using a list name as the From will not work - the mail infrastructure blocks such mail when it is submitted.

rjsparks · 2025-08-18T17:44:16Z

I'm taking this PR and finishing it out. @nouralmaa, please don't add any new commits. I'll be pushing into this branch. (I'm discovering many things that need to be touched - there are multiple views dealing with the different workflows for draft adoption that need to be included).

rjsparks · 2025-08-18T22:49:53Z

There's a bit more for me to do here - I'll move this further along soon.

The weeks-of-duration chosen in the forms isn't being passed to the mail function
Right now, this is WG specific, and it probably should be as it's about IPR rules, but it will currently send the email for groups that re not wg.
The duration runs into the deadline issue that exists elsewhere, and maybe this is where we bring in Anywhere-On-Earth.

rjsparks · 2025-08-19T14:31:22Z

Leaving the AoE change to the global one that's coming for the datatracker

codecov · 2025-08-19T15:04:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.73%. Comparing base (f5df667) to head (32afade).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9322      +/-   ##
==========================================
- Coverage   88.74%   88.73%   -0.01%     
==========================================
  Files         320      320              
  Lines       41674    41807     +133     
==========================================
+ Hits        36984    37098     +114     
- Misses       4690     4709      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

feat(documents): add auto-generated IPR email notifications on WG Cal…

a00c352

…l for Adoption or WG Last Call

evyncke reviewed Aug 8, 2025

View reviewed changes

fix: edit call durations in mails and call logic under new_state in v…

37859ab

…iews

nouralmaa force-pushed the wg-ipr-notifs branch from f94d247 to 37859ab Compare August 8, 2025 08:48

fix: calc end_date as 7 * call_duration

b068391

rjsparks requested changes Aug 11, 2025

View reviewed changes

nouralmaa and others added 3 commits August 13, 2025 10:03

Merge branch 'ietf-tools:main' into wg-ipr-notifs

d6c236a

feat(mailtrigger): added new mailtrigger for wg-lc and rfc stream states

2f09a5f

Merge branch 'wg-ipr-notifs' of github.com:nouralmaa/datatracker into…

7d576f3

… wg-ipr-notifs

nouralmaa added 2 commits August 16, 2025 08:11

Merge branch 'main' into wg-ipr-notifs

20bab8d

test: add mailtrigger test fixtures and new tests

2feab74

rjsparks changed the title ~~feat(documents): add auto-generated IPR email notifications on WG Call for Adoption or WG Last Call~~ feat: add auto-generated IPR email notifications on WG Call for Adoption or WG Last Call Aug 18, 2025

rjsparks added 3 commits August 18, 2025 11:35

fix: use two action-oriented mailtrigger names

453ba66

The two actions have the same recipients to start with, but that may change over time. Mailtrigger names should describe "what happened to trigger this email?". Changed the utility names to match the actions.

fix: send from whomever issued the call

b23bea8

Using a list name as the From will not work - the mail infrastructure blocks such mail when it is submitted.

chore: revert ietf/doc/tests_draft.py

6ebb184

rjsparks added 4 commits August 18, 2025 13:58

fix: trigger call for adoption email from manage adoption view

5830504

fix: changed template names to match functions

69695a0

fix: match the subject requested in the issue

19beec3

fix: Initial tests

252d450

rjsparks added 3 commits August 19, 2025 09:10

fix: pass duration to the email message generator

8402b49

fix: only issue the c-adopt and wg-lc email for ietf-stream docs

b42ac5e

chore: remove stray whitespace

32afade

rjsparks approved these changes Aug 19, 2025

View reviewed changes

rjsparks requested a review from jennifer-richards August 19, 2025 14:30

jennifer-richards approved these changes Aug 19, 2025

View reviewed changes

rjsparks merged commit 566cf50 into ietf-tools:main Aug 19, 2025
10 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2025

feat: add auto-generated IPR email notifications on WG Call for Adoption or WG Last Call #9322

feat: add auto-generated IPR email notifications on WG Call for Adoption or WG Last Call #9322

Uh oh!

Conversation

nouralmaa commented Aug 7, 2025 • edited by rjsparks Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jennifer-richards commented Aug 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rjsparks left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nouralmaa Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rjsparks commented Aug 15, 2025

Uh oh!

nouralmaa commented Aug 16, 2025

Uh oh!

rjsparks commented Aug 18, 2025

Uh oh!

rjsparks commented Aug 18, 2025

Uh oh!

rjsparks commented Aug 19, 2025

Uh oh!

codecov bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nouralmaa commented Aug 7, 2025 •

edited by rjsparks

Loading

nouralmaa Aug 13, 2025 •

edited

Loading

codecov bot commented Aug 19, 2025 •

edited

Loading