fix: normalize 3gpp groups and resolve duplication #9505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-richards
requested changes
Sep 12, 2025
There was a problem hiding this comment.
I think one more precondition check would be a good idea to ensure this doesn't fail.
From the email thread on the subject, I think we also need a fixup of the name for 3gpp-tgst-wg2 to remove hyphens and of 3gpp-tsg-ct for capitalization if we want to be completely consistent. Those could easily be done through the admin though.
jennifer-richards
previously approved these changes
Sep 12, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9505 +/- ##
==========================================
+ Coverage 88.75% 88.85% +0.10%
==========================================
Files 320 319 -1
Lines 41834 41812 -22
==========================================
+ Hits 37128 37152 +24
+ Misses 4706 4660 -46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jennifer-richards
approved these changes
Sep 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.