fix: don't trust libmagic charset recognition #9815
Merged
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
approved these changes
Oct 28, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9815 +/- ##
==========================================
- Coverage 88.55% 88.54% -0.01%
==========================================
Files 316 316
Lines 42256 42261 +5
==========================================
+ Hits 37420 37422 +2
- Misses 4836 4839 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because libmagic does not examine a file's full contents, it sometimes mistakes utf-8 or other encodings for ascii. To avoid failures when it's wrong, treat ascii as utf-8 by default, and fall back to latin-1 (iso8859-1) if that fails.
Always encode rendered markdown as utf-8, falling back to its original charset is silly.