Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rpcross
Copy link
Collaborator

@rpcross rpcross commented Aug 21, 2025

No description provided.

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. I assume you've run the tests and done some testing with it?

In the "due diligence" department: Django's upgrade recommendation is to step from one minor version to the next (https://docs.djangoproject.com/en/5.2/howto/upgrade-version/, end of the "Required Reading" section). That doesn't mean a release at each step, but just pointing to make sure you looked through the release notes at each 5.x.0 step along the way. I had a quick skim and didn't see anything that looked like it would need attention but you'd know better than I do.

@rpcross
Copy link
Collaborator Author

rpcross commented Aug 25, 2025

Yes, all tests run. I have read through the release notes for 5.0, 5.1, 5.2.

@rpcross rpcross merged commit 08aed3f into ietf-tools:main Aug 25, 2025
2 checks passed
@rpcross rpcross deleted the django5 branch August 25, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants