feat: Modern footer #448
Merged
feat: Modern footer #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add wagtail-factories dependency * Refactor and extend existing tests * More tests for ietf.forms * Skip blocks that are impractical to test * Tests for bibliography * Tests for cache purging * Tests for megamenu * Blog and IESG statement filtering * Tests for snippets * Remove unnecessary OrderedSet implementation * Remove unnecessary `HomePageBase` class * Tests for search and 500 page * Convert tests to pytest format * Tests for IAB pages * Normalize tests to pytest style * Add comment to bibliography extraction code * Use `LazyAttribute` to generate `slug` values * Add factory fakers for required fields * Import `signal_handlers` inside `ready()` * Better documentation * More comments --------- Co-authored-by: Kesara Rathnayake <[email protected]>
* feat: Styling for blockquotes * Allow empty cells in typed tables * Render empty float blocks as blank * Fix migrations
* Extract StructValue class for LinkBlock * Add footer columns * Move social icons to footer * Preview in Wagtail snippet editor * Tests for the footer * Responsive styling * Make the footer expansion accessible * Make tests work after rebasing onto `main` branch * Add wagtail-factories dependency * Improve accessibility * Add some comments --------- Co-authored-by: Kesara Rathnayake <[email protected]>
* feat: Styling for blockquotes * Adjust colours --------- Co-authored-by: Kesara Rathnayake <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
===========================================
+ Coverage 82.81% 96.08% +13.27%
===========================================
Files 126 153 +27
Lines 2612 3293 +681
===========================================
+ Hits 2163 3164 +1001
+ Misses 449 129 -320 ☔ View full report in Codecov by Sentry. |
microamp
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes multiple updates: