Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kesara
Copy link
Member

@kesara kesara commented Jun 10, 2024

Fixes #463

@kesara kesara requested a review from microamp June 10, 2024 21:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (ee2a89c) to head (c62b412).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         153      153           
  Lines        3293     3293           
=======================================
  Hits         3164     3164           
  Misses        129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@microamp
Copy link
Contributor

We now run collectstatic when we build a new image. See #427 for more info.

Is there a need to run it dynamically?

@kesara
Copy link
Member Author

kesara commented Jun 10, 2024

We now run collectstatic when we build a new image. See #427 for more info.

Is there a need to run it dynamically?

Not running it dynamically if the static directory is mounted directory causes issues.
This is especially required when running on a read-only filesystem where only select directories are mounted as writable.
There's no harm in running this again if the directory is writable.

@kesara
Copy link
Member Author

kesara commented Jun 10, 2024

@microamp I'm closing this, with the caveat that /static doesn't need to be updated from time to time.
If it does, DO implementation will need to mount a writable directory for /static and run this command in init.sh.

@kesara kesara closed this Jun 10, 2024
@kesara kesara deleted the build/collectstatic branch August 4, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run collectstatic command in docker image

3 participants