Remove redundant log message #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: |
|
Explain why redundant, with screenshot or example? |
|
This log message is prone to too much repetition. Logging with the name of the shelf is enough. No need to repeat messages about every shelf with similar name found like: |
holta
reviewed
Mar 27, 2024
| .first() is None | ||
|
|
||
| if not is_shelf_name_unique: | ||
| log.error("A public shelf with the name '{}' already exists.".format(title)) |
There was a problem hiding this comment.
Any chance the line should be commented out and clarified, e.g. as follows?
# log.info("A public shelf with similar name '{}' already exists.".format(title))
holta
reviewed
Mar 27, 2024
cps/shelf.py
Outdated
|
|
||
| if not is_shelf_name_unique: | ||
| log.error("A public shelf with the name '{}' already exists.".format(title)) | ||
| # log.error("A public shelf with the name '{}' already exists.".format(title)) |
There was a problem hiding this comment.
Suggested change
| # log.error("A public shelf with the name '{}' already exists.".format(title)) | |
| # log.info("A public shelf with similar name '{}' already exists.".format(title)) |
Co-authored-by: A Holt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.