Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Safer lb-wrapper: Wrap [most] lb parameters (bash vars) in single quotes #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 19, 2024
Merged

Safer lb-wrapper: Wrap [most] lb parameters (bash vars) in single quotes #195

merged 2 commits into from
Jun 19, 2024

Conversation

@holta
Copy link
Member

@holta holta commented Jun 19, 2024

@deldesir does this work? Safe enough for now?

(Per @codewiz recommendation.)

@holta holta added the enhancement New feature or request label Jun 19, 2024
@holta holta requested a review from deldesir June 19, 2024 18:45
@deldesir
Copy link
Collaborator

deldesir commented Jun 19, 2024 •
edited
Loading

I got this error message:

root@box:~# lb-wrapper dl https://www.youtube.com/watch?v=PRg5RNU_JLk
/usr/local/bin/lb
/usr/local/bin/yt-dlp
2024-06-19 14:56:06 - [Info] Using yt-dlp 2024.05.27
2024-06-19 14:56:06 - [Info] Running xklb command: lb dl '/library/calibre-web/xklb-metadata.db' --video --search 'https://www.youtube.com/watch?v=PRg5RNU_JLk' '--format best --format-sort 'tbr~1000'' --write-thumbnail --subs -o ''/library/downloads/calibre-web/%(extractor_key,extractor)s/%(uploader,uploader_id)s/%(title).170B_%(view_count)3.2D_[%(id).64B].%(ext)s'' '-vv'
2024-06-19 14:56:06 - [Error] Error 2 occurred while running lb-wrapper's xklb commands.
2024-06-19 14:56:06 - [Debug] /usr/local/bin/lb-wrapper: eval: line 96: syntax error near unexpected token `('
root@box:~# 2024-06-19 14:56:06 - [Debug] /usr/local/bin/lb-wrapper: eval: line 96: `lb dl '/library/calibre-web/xklb-metadata.db' --video --search 'https://www.youtube.com/watch?v=PRg5RNU_JLk' '--format best --format-sort 'tbr~1000'' --write-thumbnail --subs -o ''/library/downloads/calibre-web/%(extractor_key,extractor)s/%(uploader,uploader_id)s/%(title).170B_%(view_count)3.2D_[%(id).64B].%(ext)s'' '-vv''

@codewiz
Copy link

codewiz commented Jun 19, 2024

Looks good to me now.

deldesir
deldesir approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@deldesir deldesir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected for me now. I tested it on Ubuntu 24.04.

@holta
Copy link
Member Author

holta commented Jun 19, 2024

I got this error message:

Apologies. Is this fixed PR now good enough?

@holta holta merged commit 2d76adc into iiab:master Jun 19, 2024
@holta holta changed the title Safer lb-wrapper: Wrap lb parameters (bash vars) in single quotes Safer lb-wrapper: Wrap [most] lb parameters (bash vars) in single quotes Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deldesir deldesir deldesir approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@holta @deldesir @codewiz