Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@deldesir
Copy link
Collaborator

This PR introduces --live so live videos can be downloaded. It was tested with a fork of xklb with the changes proposed in chapmanjacobd/library#41

image

@holta
Copy link
Member

holta commented Jun 25, 2024

There needs to be a deeper discussion about what "live" YouTube videos really mean.

Forthrightly acknowledging the differences between "actually live" YouTube videos and "formerly live" YouTube videos (and the dramatically different end-user consequences of downloading both kinds) will move this design process forward, with sincere respect for all people involved.

Please help articulate what's really needed in the design discussion here:

yt-dlp flag to download livestreams from the start
@holta
Copy link
Member

holta commented Jun 26, 2024

Looks good!

Please test with all 3+ kinds of "ostensibly live" YouTube videos: (and please explain what happens in each case)

  1. Not Yet Live
  2. Actually Live
  3. Formerly Live

Actual test cases are posted here, to help with testing:

@holta
Copy link
Member

holta commented Jun 27, 2024

Please test with all 3+ kinds of "ostensibly live" YouTube videos: (and please explain what happens in each case)

  1. Not Yet Live
  2. Actually Live
  3. Formerly Live

RECAP: To help push this PR forward, please take very seriously all 3 kinds of test cases outlined at...

@deldesir
Copy link
Collaborator Author

deldesir commented Jun 28, 2024

  1. Not Yet Live: https://www.youtube.com/watch?v=oxBc0e-bKOk
    image

  2. Actually Live: https://www.youtube.com/watch?v=5kw8ywYmVz4
    image

  3. Formerly live: https://www.youtube.com/watch?v=vpBqz11OhR4
    image

"Not yet live" and "Actually live" videos do not have a duration yet. This is the reason they are reported as "not available" in Calibre-Web.

xklb-metadata.db live_status values for:
Not yet live: is_upcoming
Actually live: is_live
Formerly live: was_live
image

@deldesir
Copy link
Collaborator Author

deldesir commented Jun 28, 2024

Regression / Known issue (introduced by this PR):

"Upcoming live" and "Actually live" videos are caught in subsequent downloads as requested videos. They will remain as such until they are available, that means having a duration value.

image

The PR can be merged though. A new PR should addressed this regression by automatically deleting these videos records from xklb-metadata.db

@holta
Copy link
Member

holta commented Jun 28, 2024

"Upcoming live" and "Actually live" videos are caught in subsequent downloads as requested videos. They will remain as such until they are available, that means having a duration value.

Thanks @deldesir for explaining, alongside:

  • Vital screenshots above, making clear our 3 primary cases
  • xklb-metadata.db's corresponding live_status values {is_upcoming, is_live, was_live}

Follow-up PR will clean up and clarify very soon, as outlined here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants