-
Notifications
You must be signed in to change notification settings - Fork 11
Add --live flag to support downloading of "live" videos #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There needs to be a deeper discussion about what "live" YouTube videos really mean. Forthrightly acknowledging the differences between "actually live" YouTube videos and "formerly live" YouTube videos (and the dramatically different end-user consequences of downloading both kinds) will move this design process forward, with sincere respect for all people involved. Please help articulate what's really needed in the design discussion here: |
yt-dlp flag to download livestreams from the start
|
Looks good! Please test with all 3+ kinds of "ostensibly live" YouTube videos: (and please explain what happens in each case)
Actual test cases are posted here, to help with testing: |
RECAP: To help push this PR forward, please take very seriously all 3 kinds of test cases outlined at... |
"Not yet live" and "Actually live" videos do not have a duration yet. This is the reason they are reported as "not available" in Calibre-Web. xklb-metadata.db live_status values for: |
|
Regression / Known issue (introduced by this PR): "Upcoming live" and "Actually live" videos are caught in subsequent downloads as requested videos. They will remain as such until they are available, that means having a duration value. The PR can be merged though. A new PR should addressed this regression by automatically deleting these videos records from xklb-metadata.db |
Thanks @deldesir for explaining, alongside:
Follow-up PR will clean up and clarify very soon, as outlined here: |
This PR introduces
--liveso live videos can be downloaded. It was tested with a fork of xklb with the changes proposed in chapmanjacobd/library#41