Is it necessary to hard-code /books/media in 2 different places?

https://github.com/deldesir/calibre-web/blob/60e9c77f0161298171518710294f723c7852a7a4/cps/static/js/main.js#L218
https://github.com/deldesir/calibre-web/blob/60e9c77f0161298171518710294f723c7852a7a4/cps/static/js/main.js#L251

Is DRY / SSOT not possible in this situation?

ASIDE: Hard-coding is fine for now, but in future months (if future-proof automation is genuinely safe!) then we can consider driving off of...

/etc/iiab/local_vars.yml customized variables like these three:

calibreweb_url1: /books     # For SHORT URL http://box/books  (English)
calibreweb_url2: /libros    # For SHORT URL http://box/libros (Spanish)
calibreweb_url3: /livres    # For SHORT URL http://box/livres (French)

https://github.com/iiab/iiab/blob/579cfac36eca6e8c3916b4d91fa4c430bbf69cbf/vars/default_vars.yml#L661-L663

...as mentioned in:

• Media download request fails on standard endpoints [RE: hardcoded /live/media in main.js AND /books /libros /livres ETC] #25 (comment)

@deldesir thanks for the excellent, long & edifying design review earlier this morning. 💯

Quick summary:

• Indentation issues (accidental nesting of function downloadMedia [Line 191] within function initiateMediaDownload [Line 172] ?) currently being investigated...
• Avoid dragging in other PRs whenever possible (so tight/compact PRs are much more readable in future!) e.g. the 3 snippets below... don't look like they belong here in this particular PR?
  • Line 255: $(document).on('keydown', function(event) { (Enter key press event handling)
  • Line 266: $("input[name='videoQuality']").change(function() {
  • Line 271: $("#maxVideos").on('input', function() {
• Ongoing investigation of POST headers like HTTP_REFERER and Filename — that Firefox's console apparently makes much more visible than Chrome's — so we can hopefully entirely avoid hard-coding AND soft-coding /books/media /libros/media /livres/media (ETC) ?
  • https://github.com/iiab/iiab/blob/579cfac36eca6e8c3916b4d91fa4c430bbf69cbf/vars/default_vars.yml#L661-L663
  • https://github.com/iiab/iiab/blob/master/roles/calibre-web/templates/calibre-web-nginx.conf.j2

Feel free to re-work this PR in-place — or perhaps to replace it with an entirely new PR — either way! ✅

Fantastic progress.

No matter if a future PR later steers this in a slightly different direction.

Now, we get the path in a better way by just extracting the last part of the current url and add the endpoint to it.

Looks incredible! If in addition, HTTP_REFERER's also no longer being used!