(re)name bundled yt-dlp as iina-ytdl instead of youtube-dl
#5758
+28
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4e1fd2 to
2551bc6
Compare
2551bc6 to
ecb47b9
Compare
2143a00 to
0e532c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I am working on the official IINA plugin
Online Mediaand found out that there's no way in the plugin API to distinguish between executables having the same name on the system$PATHand IINA's executable directory - in my case - it isyoutube-dl.The
JavascriptAPIUtils.findInPathsearches in, both, system$PATHand IINA's executable directory (IINA.app/Contents/MacOS/).More than overcoming this limitation of the API, I think prefixing the executable name with "iina-" to give it a specialised name is a more appropriate solution.
NOTE: (I am forced to make this PR as I need this distinction for the plugin work I am doing) I don't know the Swift language, nor
libmpv. This PR could be flat out wrong and broken, and I am extremely sorry for that if that's the case. Please bear with me.