Thanks to visit codestin.com
Credit goes to github.com

Skip to content

RFC. Command (allow to assign a hotkey) for toggling auto-hiding of On Screen Controller #5798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
beyondcompute wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

RFC. Command (allow to assign a hotkey) for toggling auto-hiding of On Screen Controller #5798

beyondcompute wants to merge 8 commits into from

Conversation

@beyondcompute
Copy link

@beyondcompute beyondcompute commented Nov 6, 2025 •
edited
Loading

Description:
There was an idea to add a hotkey to briefly show the UI (without the need to move the mouse, for example). But perhaps it would be also nice to have a hotkey to enable-disable the UI auto-hiding itself. The screenshot below shows the setting that we toggle via a hotkey basically.

Screenshot of Iina app settings view, with an arrow pointing at the checkbox next to the “Auto hide after” setting

Here’s a screenshot of a debug build of the implementation:
Screenshot of Iina keyboard shortcuts settings, show adding a new shortcut with a “Toggle On Screen Controller auto-hiding” option highlighted

Screenshots of the player window with OSD messages Screenshot of Iina player window with an on-screen alert message saying “On Screen Controller always visible” Screenshot of Iina player window with an on-screen alert message saying “Auto-hiding On Screen Controller”

This PR is just a suggestion (hence titled as an “RFC”), feel free to close or to request style changes. Thank you! 🙏

Warning

This is an AI-assisted work 🤷‍♂️

@beyondcompute
Copy link
Author

beyondcompute commented Nov 7, 2025 •
edited
Loading

I noticed another thing, not related to this change. Currently if we have .enableControlBarAutoHide == false, main window’s title bar does not hide either. Is this intended behavior? Should I attempt to address that (in a separate PR perhaps), to make the .enableControlBarAutoHide Preference only affect showing and hiding of the control bar itself?

Here’s a sketch of an implementation in my fork, on top of this branch: https://github.com/beyondcompute/iina/pull/1/files

@beyondcompute beyondcompute force-pushed the command-for-toggling-control-bar-auto-hide branch 2 times, most recently from 76f8152 to d628437 Compare November 8, 2025 00:24
@beyondcompute beyondcompute mentioned this pull request Nov 8, 2025
Draft
@beyondcompute beyondcompute force-pushed the command-for-toggling-control-bar-auto-hide branch from d628437 to 085cab7 Compare November 23, 2025 23:09
@beyondcompute beyondcompute changed the title RFC: Command (allow to assign a hotkey) for toggling auto-hiding of On Screen Controller RFC. Command (allow to assign a hotkey) for toggling auto-hiding of On Screen Controller Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@beyondcompute