player,ui: Option+scroll 0.25x speed step; add OSC speed chip #5807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a keyboard modifier-based playback speed adjustment. Default proportional scroll behavior remains unchanged; the discrete stepping path is active only while the Option key is held.
This allows the user to quickly change the playback speed multiplier to [0.25, 0.5 ... 3.75, 4.0] inclusive.
- Add 0.25x stepping for playback speed when holding Option while
scrolling. Mouse wheel notches step ±0.25x per notch; trackpad precise
scrolling accumulates until a full step is reached.
- Keep proportional scroll behavior unchanged when no modifier is pressed.
- Show a compact speed "chip" in Top/Bottom OSC layouts when speed != 1.00x;
hide it at exactly 1.00x. Floating layout continues to use the
left/right arrow labels.
- Centralize the scroll upper bound via
PlayerWindowController.playbackSpeedScrollUpperBound (4.0) so both
paths stay consistent.
- Add PlaybackSpeedStep.swift with pure 0.25x stepping helpers (clamp,
snap, step) for reuse and testability.
- Wire up oscSpeedChipLabel in MainWindowController.xib and update
label visibility when layout changes.
UI/XIB: update Base.lproj/MainWindowController.xib; no new localizable strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a keyboard modifier-based playback speed adjustment. Default proportional scroll behavior remains unchanged; the discrete stepping path is active only while the Option key is held.
This allows the user to quickly change the playback speed multiplier to [0.25x, 0.5x ... 3.75x, 4.0x] inclusive. The user can now quickly switch between standard playback speeds without excessive scrolling.
Example gif showing the behavior when the Option key is held down while scrolling.
UI/XIB: update Base.lproj/MainWindowController.xib; no new localizable strings.