Fix large files loaded in RAM, 86 GB in use by IINA, #5803 #5818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Change the searchTracksForArtwork method in the NowPlayingInfoManager class to not support picture files - Add additional logging in the constructImage method - Add a log message to the readArtworkFromURL method in the FFmpegController class It is difficult for searchTracksForArtwork to detect if the media being played is a picture. Instead for pictures NowPlayingInfoManager will rely upon QLThumbnailGenerator to generate artwork for the Now Playing module.
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
searchTracksForArtworkmethod in theNowPlayingInfoManagerclass to not support picture filesreadArtworkFromURLmethod in theFFmpegControllerclassIt is difficult for
searchTracksForArtworkto detect if the media being played is a picture. Instead for picturesNowPlayingInfoManagerwill rely uponQLThumbnailGeneratorto generate artwork for the Now Playing module.Description: