Change get/setFlag to use Int32 for MPV_FORMAT_FLAG #5824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Change MPVController.getFlag to use Int32 instead of Int64 when calling mpv_get_property - Change MPVController.setFlag to use Int32 instead of Int when calling mpv_set_property Using 64 bit integers is working, but is not technically correct. A MPV_FORMAT_FLAG is a 32 bit integer. MPVController correctly uses Int32 for other libmpv client APIs that use 32 bit integers. These changes align these two methods with that convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
MPVController.getFlagto useInt32instead ofInt64when callingmpv_get_propertyMPVController.setFlagto useInt32instead ofIntwhen callingmpv_set_propertyUsing 64 bit integers is working, but is not technically correct. A
MPV_FORMAT_FLAGis a 32 bit integer.MPVControllercorrectly usesInt32for otherlibmpvclient APIs that use 32 bit integers. These changes align these two methods with that convention.Description: