Seek to time in url if such query parameter is present#5370
Open
iThinker wants to merge 2 commits intoiina:developfrom
Open
Seek to time in url if such query parameter is present#5370iThinker wants to merge 2 commits intoiina:developfrom
iThinker wants to merge 2 commits intoiina:developfrom
Conversation
Contributor
Author
Contributor
|
Sounds like a good addition for YT-DL. But seems there is a (probably small) but nonzero probability that this may cause problems with URLs which have "t" or "time" query params in their URLs which are expected to be passed through to the server? |
Contributor
Author
|
The params are not stripped, so they would be passed to the server, aren't they? Or there is some stripping logic elsewhere? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t/timeparameter in URL scheme #5334.Description:
Parse time parameters from URL query and seek to it of present.
Tested with pasting URL from youtube.
It might be nice to improve browser extension to support adding time somehow. But I dunno how it would get time from playing web video.