This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Add ability to fetch posts by project and page #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoraCodes
commented
Nov 4, 2022
| .map(|project| project.handle) | ||
| .collect(); | ||
| if related_projects.is_empty() { | ||
| related_projects.push(api.posting_project.handle.clone()); |
There was a problem hiding this comment.
The Cohost API doesn't include the poster's handle unless there is something in the share tree. For consistency I push it in here if it's missing.
iliana
approved these changes
Nov 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this API looks okay. My main thought would be that it might not be desirable to re-use the existing post type; if that's true, I'm happy to split that off into a separate read-specific Post type.
In addition, there's the problem of share trees. I'm tempted to provide an option that doesn't deserialize it in whole. However, because it's not permitted in the API to get a single post by ID, we can't just provide the share tree IDs and leave it at that. As I see it, the options are:
Personally, I favor the latter.