Add Float64 Support #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 79.89% 80.51% +0.62%
==========================================
Files 12 12
Lines 562 580 +18
Branches 110 113 +3
==========================================
+ Hits 449 467 +18
Misses 106 106
Partials 7 7 ☔ View full report in Codecov by Sentry. |
|
Thanks! Why can't you attach an image ? Is it because of their size? We need at least one for the test cases. |
|
Maybe we can use this library to generate a test image. |
|
Sorry, github didn't allow uploading .TIFF files but simply zipping it solves this problem. Attached is a float64 .TIFF file I used for testing. |
|
Can you add one to the img folder and update the test to include it here? |
|
The image and test have been added successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
float64support for decoding.tifffiles. This is in reference to issue #58.The changes are relatively minor. This has been tested and works. I can't attach an example file here, but the data provided here is
float64Geodatenviewer der Stadt Wien.Additionally, since I have been testing this locally, I used
npm packto make the module available locally to me. I added.tgzfiles to the.gitignore, but this change is not strictly necessary.