Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@braxtonchristensen
Copy link
Contributor

#144
implement useFullscreen

Oct-10-2019 22-37-19

add missing feilds to package.json
@braxtonchristensen
Copy link
Contributor Author

For example, why do we need to expose the element? Shouldn't that be passed as an argument?

It is an optional argument if you wanted to make the entire app fullscreen you wouldn't pass request or toggle any arguments this will by default target the root of the application.

If you have multiple things that can go full screen it might be helpful to be able to use this property to know what is fullscreen at the moment.

* move to forEach
* remove anonymous func in favor of fat arrow
* move logic to its on file
* add index responsible for only exporting (like useMouse)
* fix default state to derive from document
@imbhargav5
Copy link
Owner

We should still go for array destructing to make it easy for us to add more return values later without breaking previous releases. Let's figure out a way to put the most relevant ones at the first few indices in the array.

return array instead of object
update readme example
@imbhargav5
Copy link
Owner

@braxtonchristensen Really sorry about the delay here. Life intervened. Had very little time to maintain rooks until now. Have finally found sometime now. Going to merge this after a few fixes in the next couple of days.

@imbhargav5 imbhargav5 changed the base branch from dev to master December 24, 2019 18:56
@imbhargav5 imbhargav5 added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Dec 25, 2019
@imbhargav5
Copy link
Owner

/rebase

1 similar comment
@imbhargav5
Copy link
Owner

/rebase

@imbhargav5 imbhargav5 changed the base branch from master to use-fullscreen December 25, 2019 08:02
@imbhargav5 imbhargav5 merged commit 412aa22 into imbhargav5:use-fullscreen Dec 25, 2019
imbhargav5 added a commit that referenced this pull request Dec 25, 2019
* Feat/144/add use fullscreen (#150)

* feat: add useFullscreen

add useFullscreen hook

* fix: update package.json

add missing feilds to package.json

* fix(fullscreen): PR fixes and project standards

* move to forEach
* remove anonymous func in favor of fat arrow
* move logic to its on file
* add index responsible for only exporting (like useMouse)

* fix(fullscreen): default state should be derived from document

* fix default state to derive from document

* fix(fullscreen): return array

return array instead of object

* fix(fullscreen): update readme

update readme example

* Add useFullscreen hook

Co-authored-by: Braxton Christensen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: New Feature 🚀 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants