-
-
Notifications
You must be signed in to change notification settings - Fork 219
Feat/144/add use fullscreen #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/144/add use fullscreen #150
Conversation
add useFullscreen hook
add missing feilds to package.json
It is an optional argument if you wanted to make the entire app fullscreen you wouldn't pass If you have multiple things that can go full screen it might be helpful to be able to use this property to know what is fullscreen at the moment. |
* move to forEach * remove anonymous func in favor of fat arrow * move logic to its on file * add index responsible for only exporting (like useMouse)
* fix default state to derive from document
|
We should still go for array destructing to make it easy for us to add more return values later without breaking previous releases. Let's figure out a way to put the most relevant ones at the first few indices in the array. |
return array instead of object
update readme example
|
@braxtonchristensen Really sorry about the delay here. Life intervened. Had very little time to maintain rooks until now. Have finally found sometime now. Going to merge this after a few fixes in the next couple of days. |
|
/rebase |
1 similar comment
|
/rebase |
* Feat/144/add use fullscreen (#150) * feat: add useFullscreen add useFullscreen hook * fix: update package.json add missing feilds to package.json * fix(fullscreen): PR fixes and project standards * move to forEach * remove anonymous func in favor of fat arrow * move logic to its on file * add index responsible for only exporting (like useMouse) * fix(fullscreen): default state should be derived from document * fix default state to derive from document * fix(fullscreen): return array return array instead of object * fix(fullscreen): update readme update readme example * Add useFullscreen hook Co-authored-by: Braxton Christensen <[email protected]>
#144
implement
useFullscreen