Remove umd and cjs module support #1855
Conversation
Co-authored-by: imbhargav5 <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for rooksjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Summary of Changes
Hello @imbhargav5, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors the project's module output strategy by removing support for UMD and CommonJS (CJS) formats, standardizing on ECMAScript Modules (ESM) only. This change simplifies the build pipeline, reduces the project's footprint, and aligns the library with modern JavaScript development practices. It impacts the build configuration, package metadata, and related documentation and testing scripts.
Highlights
- Simplified Build Process: The build process has been streamlined by removing the generation of UMD and CJS module formats, focusing solely on ESM. This simplifies the build configuration and reduces the number of output artifacts.
- Updated Package Configuration: The
package.jsonhas been updated to reflect the exclusive use of ESM, including the addition of"type": "module"and adjustments to theexportsfield. This ensures proper module resolution for consumers. - Removed Legacy Module Support: All references and configurations related to UMD and CJS, including size limits and sanity checks, have been removed from the repository. This cleans up the codebase and aligns documentation with the new module strategy.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request effectively removes UMD and CJS module support, transitioning the project to be ESM-only. The changes to the build process, package configuration, and related scripts are consistent and well-executed. I've provided a couple of suggestions to further improve the codebase. Additionally, please consider updating the engines.node version in package.json to a version that fully supports ESM (e.g., >=14.0.0) and updating the README files to remove mentions of UMD/CJS support, as these parts were not in the diff. Overall, this is a great step forward in modernizing the package.
Co-authored-by: imbhargav5 <[email protected]>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request contains changes generated by Cursor background composer.