feat: modernize useMediaMatch with useSyncExternalStore #1892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for rooksjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Refactor useMediaMatch to use React 18's useSyncExternalStore for better concurrent mode safety and proper SSR handling. Fixes Rules of Hooks violation and removes legacy browser API support. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
3295d7c to
4cefe49
Compare
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
useMediaMatchto use React 18'suseSyncExternalStorefor better concurrent mode safety and proper SSR handling. The public API remains unchanged - this is an internal modernization with no breaking changes.Key Improvements
getServerSnapshotinstead of conditional returnsaddListener/removeListenerAPI support (deprecated since Safari 14)Testing
All 1011 tests pass. TypeScript compilation succeeds with no errors.
🤖 Generated with Claude Code