Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: transition to maven central for deploys #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
luqven merged 9 commits into from
Mar 24, 2021
Merged

chore: transition to maven central for deploys #65

luqven merged 9 commits into from
Mar 24, 2021

Conversation

@luqven
Copy link
Contributor

@luqven luqven commented Mar 16, 2021 •
edited
Loading

Description

This PR introduces gradle.build changes that should allow us to transition to publishing our library on the maven central repository.

@luqven luqven self-assigned this Mar 16, 2021
@commit-lint
Copy link

commit-lint bot commented Mar 16, 2021 •
edited
Loading

Chore

  • transition to maven central for deploys (de2d930)
  • update build.grade to hit correct endpoints (6a9f43e)
  • add gradle-nexus-plugin capabilites (28eed4d)
  • sign files using env variables (a3c5817)
  • remove repo field and use env vars for auth (7160b5b)
  • change jdk version to 8 for travis compat (562887a)
  • update comments and add pom validation plugin (ec11624)
  • add comments to build.gradle explaining utf8 task (787a22c)

Documentation

  • add maven badge to README.md (ded32cc)

Contributors

luqven

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@luqven
Copy link
Contributor Author

luqven commented Mar 17, 2021

Tried every which way to change the gradle syntax to account for uploadArchives being deprecated but kept getting some very cryptic errors. For now, we have a build deployed to maven central (won't show up for another few hours) but this gradle script will stop working soonish. Next release might not be able to use it.

TDLR: we can now upload to maven central (once gradle.properties is defined locally) but this fix will not work long.

@luqven
Copy link
Contributor Author

luqven commented Mar 17, 2021

Somehow I've managed it. The entire build-deploy process is now handled in the build.gradle file. Some env variables are assumed.

@sherwinski sherwinski linked an issue Mar 17, 2021 that may be closed by this pull request
Move from Bintray/JCenter to Maven Central #64
Closed
@luqven
Copy link
Contributor Author

luqven commented Mar 18, 2021

And we're live on the sonatype maven central search 🎉

@luqven luqven marked this pull request as ready for review March 18, 2021 18:33
@luqven luqven requested a review from a team as a code owner March 18, 2021 18:33
@frederickfogerty
Copy link
Contributor

frederickfogerty commented Mar 19, 2021

Congrats on this 👏

@csummers
Copy link

csummers commented Mar 19, 2021

Just a note that the imgix-java-2.3.0.jar file currently on Maven Central only contains .java source files, and not compiled .class files, so I think something is missing here. Thanks!

@luqven
Copy link
Contributor Author

luqven commented Mar 19, 2021

Just a note that the imgix-java-2.3.0.jar file currently on Maven Central only contains .java source files, and not compiled .class files, so I think something is missing here. Thanks!

Hey csummers, thanks for reporting this. We're aware of the issue and it's a high priority for us to fix this. We'll share any updates we have here.

@luqven
Copy link
Contributor Author

luqven commented Mar 23, 2021

Cleaned up commits ☝🏼

For visibility, a fixed 2.3.0 release is now live

@luqven luqven requested a review from sherwinski March 23, 2021 15:13
@luqven luqven changed the title chore: test transition to maven central for deploys chore: transition to maven central for deploys Mar 23, 2021
sherwinski
sherwinski approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@sherwinski sherwinski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🚀 🚀

README.md
@@ -4,6 +4,7 @@
`imgix-java` is a client library for generating image URLs with [imgix](https://www.imgix.com/).

[![Download](https://api.bintray.com/packages/imgix/maven/imgix-java/images/download.svg) ](https://bintray.com/imgix/maven/imgix-java/_latestVersion)
Copy link
Contributor

@sherwinski sherwinski Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can safely remove this now or wait until May 1st when all Bintray accounts are deactivated.

@luqven luqven merged commit dbef976 into main Mar 24, 2021
@luqven luqven deleted the luis/maven branch March 24, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sherwinski sherwinski sherwinski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@luqven luqven

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move from Bintray/JCenter to Maven Central

5 participants

@luqven @frederickfogerty @csummers @sherwinski