fix: explicitly convert string to UTF-8 byte array #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @spand, I have a fix here for the encoding issue you opened earlier. Feel free to take a look and let me know what you think. Thanks! |
a6ca4c6 to
21203b5
Compare
nico256
reviewed
Dec 3, 2019
84069dd to
9b10b97
Compare
nico256
approved these changes
Dec 3, 2019
|
Looks good ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explicitly converts a query parameter value to UTF-8 before encoding the value to base64. Without specifying the encoding scheme explicitly, the behavior of
getBytes()and the subsequentStringinstantiation would be platform dependent, which can result in incorrectly-encoded values. By specifyingUTF-8, we can ensure the results regardless of the default charset of the calling system.Fixes #35