Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ericdeansanchez
Copy link
Contributor

The purpose of this PR is to update purger operation. In this PR the
following have been updated to support the new purger operation:

  • deprecation warnings have been removed (denoting old-style keys will
    not work in imgix-rb >= 4.0.0
  • the request body has been updated in accordance with what the new
    endpoint expects
  • the endpoint itself has been updated from v2/image/purger to
    api/v1/purge
  • the test suite has been updated to reflect the new request format

@ericdeansanchez ericdeansanchez requested a review from a team as a code owner August 18, 2020 22:45
Copy link
Contributor

@frederickfogerty frederickfogerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! No big issues so feel free to merge if you like.

Copy link
Contributor

@sherwinski sherwinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The big item of feedback relates to the request header.

@ericdeansanchez ericdeansanchez merged commit 2c3f15d into main Aug 26, 2020
@ericdeansanchez ericdeansanchez deleted the api-key-deprecation branch August 26, 2020 20:41
@ericdeansanchez ericdeansanchez changed the title fix: update purge operation fix: update purge operation api keys Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants