docs: fixed typo w/ srcset min/max widths #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdeansanchez
approved these changes
Dec 15, 2020
Contributor
ericdeansanchez
left a comment
There was a problem hiding this comment.
Hey 👋 thanks for opening this PR and catching this. We really appreciate it!
sherwinski
approved these changes
Dec 15, 2020
Contributor
sherwinski
left a comment
There was a problem hiding this comment.
Good catch, thanks @scttdavs 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple issues in the docs with
min_widthandmax_widthnot being documented correctly. I had to dig through the source code to figure out why things were not working as expected. Hopefully this saves some others some time.Checklist: Fixing typos/Doc change
chore(readme): fixed typo. See the end of this file for more information.