Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bitbound
Copy link
Contributor

DeviceClientDto's property name casings were out of alignment with Device. This created a serialization issue when agents first try to connect to an updated server. I didn't realize that the agent auto-update wouldn't happen immediately after reconnect if the DeviceCameOnline method failed.

I moved the update check to immediately after reconnect, so we can have breaking API changes like this later without any issues. For now, I realigned the property name casings. After this release, they can be corrected.


Please read the following. Do not delete below this line.

Thank you for your contribution to the Remotely project. It is required that contributors assign copyright to Immense Networks so we retain full ownership of the project.

This makes it easier for other entities to use the software because they only have to deal with one copyright holder. It also gives me assurance that we'll be able to make decisions in the future without gathering and consulting all contributors.

While this may seem odd, many open source maintainers practice this. Here are a couple well-known examples:

A nice article on the topic can be found here: https://haacked.com/archive/2006/01/26/WhoOwnstheCopyrightforAnOpenSourceProject.aspx/

By submitting this PR, you agree to the following:

You hereby assign copyright in this PR's code to the Remotely project and its copyright holder, Immense Networks, to be licensed under the same terms as the rest of the code. You agree to relinquish any and all copyright interest in the software, to the detriment of your heirs and successors.

…ter reconnection, so these can be properly cased later.
@bitbound bitbound self-assigned this Jun 24, 2023
@bitbound bitbound merged commit 402d5b0 into master Jun 24, 2023
@bitbound bitbound deleted the hotfix/agentdevicedto branch June 24, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant