Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow recent changes to be used in Erlang/OTP24 #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elbrujohalcon merged 2 commits into from
May 8, 2025
Merged

Allow recent changes to be used in Erlang/OTP24 #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb9e480
elbrujohalcon.backport-to Allow recent changes to be used in Erlang/O…
elbrujohalcon May 8, 2025
1060183
elbrujohalcon.backport-to Use older rebar3
elbrujohalcon May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ jobs:
runs-on: ${{matrix.os}}
strategy:
matrix:
otp_vsn: ['25', '26', '27']
rebar3_vsn: ['3.24']
os: [ubuntu-24.04, windows-2022]
otp_vsn: ['24']
rebar3_vsn: ['3.22']
os: [ubuntu-24.04]
steps:
- uses: actions/checkout@v4
- uses: erlef/setup-beam@v1
Expand All @@ -42,9 +42,6 @@ jobs:
-otp-${{steps.setup-beam.outputs.otp-version}}\
-rebar3-${{steps.setup-beam.outputs.rebar3-version}}\
-hash-${{hashFiles('rebar.lock')}}"
- name: Format check
if: ${{ matrix.os == 'ubuntu-24.04' && matrix.otp_vsn == '26' }}
run: rebar3 fmt --check
- name: Run test
run: rebar3 test
- name: Run elvis on elvis
Expand Down
4 changes: 1 addition & 3 deletions rebar.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

{erl_opts, [warn_unused_import, warn_export_vars, warnings_as_errors, verbose, report, debug_info]}.

{minimum_otp_vsn, "25"}.

{profiles, [
{test, [
{extra_src_dirs, ["test/examples"]},
Expand All @@ -16,7 +14,7 @@
]}
]}.

{alias, [{test, [compile, fmt, hank, xref, dialyzer, ct, cover, ex_doc]}]}.
{alias, [{test, [compile, fmt, hank, xref, dialyzer, ct, cover]}]}.

{shell, [{config, "config/test.config"}]}.

Expand Down
4 changes: 2 additions & 2 deletions src/elvis_style.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1665,7 +1665,7 @@ no_boolean_in_comparison(Config, Target, RuleConfig) ->
lists:any(IsBoolean, Content)
end,
ComparisonsWithBoolean =
lists:uniq(
lists:usort(
elvis_code:find(IsComparisonWithBoolean, Root, #{traverse => all})
),

Expand Down Expand Up @@ -1698,7 +1698,7 @@ no_operation_on_same_value(Config, Target, RuleConfig) ->
end,

OpNodes =
lists:uniq(
lists:usort(
elvis_code:find(IsInterestingOp, Root, #{traverse => all})
),

Expand Down