Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@PietrH
Copy link
Member

@PietrH PietrH commented Oct 2, 2025

UNDER CONSTRUCTION - DO NOT MERGE

See #417 and github.com/inbo/etn/milestones/8

  • Up version number

AI Summary

This pull request introduces significant updates to the etn package, focusing on modernizing its architecture, improving usability, and enhancing compatibility and reproducibility. The package now defaults to connecting via an API (using the etnservice package), deprecates direct database connection management, and streamlines credentials handling. Several dependencies and functions have been updated or removed, and documentation and citation information have been revised to reflect these changes.

Major architectural and usability changes:

  • The package now connects to the ETN database via an API using the etnservice package, with automatic switching to a local database connection if available. The connection argument is deprecated, and users are prompted for credentials if not stored in the environment. The connect_to_etn() function is also deprecated and now issues a warning instead of establishing a connection. [1] [2] [3] [4]
  • Several deprecated functions (get_deployments(), get_detections(), get_projects(), get_receivers(), list_network_project_codes()) have been removed from the package. [1] [2]

Dependency and environment management:

  • The package dependencies have been updated: new imports include arrow, askpass, cachem, cli, etnservice, httr2, lifecycle, memoise, prettyunits, rlang, and utils. Some dependencies (e.g., DBI, odbc, jsonlite, lubridate) have been removed or moved to Suggests. The Remotes field now includes GitHub sources for etnservice and vcr.
  • The GitHub Actions workflow now tests with R 4.1.0 (the minimum supported version) and passes new environment variables for credentials and VCR control.

Documentation and citation updates:

  • The NEWS.md file has been updated to document all major changes, including new connection logic, credential management, deprecations, and new features.
  • The CITATION.cff file has been updated to reflect the new version, update the preferred citation, and revise software references to match the updated dependencies. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Miscellaneous improvements:

  • A .gitattributes file was added to standardize text handling and ignore diffs in test fixtures.

These changes collectively modernize the etn package, improve user experience, and ensure consistency between API and local database queries.

References:
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]

[email protected] and others added 30 commits September 9, 2025 11:32
`get_acoustic_detections()` can now fetch more detections, with less duplicates.
@PietrH PietrH linked an issue Oct 2, 2025 that may be closed by this pull request
10 tasks
@PietrH PietrH self-assigned this Oct 2, 2025
@PietrH PietrH modified the milestone: v2.3.1: OpenCPU Release Oct 2, 2025
@PietrH PietrH added the blocked label Oct 2, 2025
Add code coverage Github Action.
@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 86.72986% with 56 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@57439a8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
R/get_acoustic_detections.R 86.87% 21 Missing ⚠️
R/utils-api.R 84.70% 13 Missing ⚠️
R/conduct_parent_to_helpers.R 87.01% 10 Missing ⚠️
R/utils.R 55.55% 8 Missing ⚠️
R/download_acoustic_dataset.R 97.22% 1 Missing ⚠️
R/forward_to_api.R 95.65% 1 Missing ⚠️
R/get_acoustic_projects.R 0.00% 1 Missing ⚠️
R/get_cpod_projects.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #418   +/-   ##
=======================================
  Coverage        ?   84.55%           
=======================================
  Files           ?       26           
  Lines           ?      725           
  Branches        ?        0           
=======================================
  Hits            ?      613           
  Misses          ?      112           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release etn API update

1 participant