-
Notifications
You must be signed in to change notification settings - Fork 5
Major ETN update: you can now use it on your own computer. #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
PietrH
wants to merge
768
commits into
main
Choose a base branch
from
v2.3.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_acoustic_detections()` can now fetch more detections, with less duplicates.
…d as httr2 includes response in condition
…te causing no matches
…ettes (detections)
…g", file = "standalone-purrr")`
…mber-in-etnget_acoustic_detections 386 include new field tag serial number in etnget acoustic detections
326 precompile vignettes
10 tasks
Switch to base pipes, use namespace prefixing for dplyr functions.
Add code coverage Github Action.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
=======================================
Coverage ? 84.55%
=======================================
Files ? 26
Lines ? 725
Branches ? 0
=======================================
Hits ? 613
Misses ? 112
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UNDER CONSTRUCTION - DO NOT MERGE
See #417 and github.com/inbo/etn/milestones/8
AI Summary
This pull request introduces significant updates to the
etnpackage, focusing on modernizing its architecture, improving usability, and enhancing compatibility and reproducibility. The package now defaults to connecting via an API (using theetnservicepackage), deprecates direct database connection management, and streamlines credentials handling. Several dependencies and functions have been updated or removed, and documentation and citation information have been revised to reflect these changes.Major architectural and usability changes:
etnservicepackage, with automatic switching to a local database connection if available. Theconnectionargument is deprecated, and users are prompted for credentials if not stored in the environment. Theconnect_to_etn()function is also deprecated and now issues a warning instead of establishing a connection. [1] [2] [3] [4]get_deployments(),get_detections(),get_projects(),get_receivers(),list_network_project_codes()) have been removed from the package. [1] [2]Dependency and environment management:
arrow,askpass,cachem,cli,etnservice,httr2,lifecycle,memoise,prettyunits,rlang, andutils. Some dependencies (e.g.,DBI,odbc,jsonlite,lubridate) have been removed or moved toSuggests. TheRemotesfield now includes GitHub sources foretnserviceandvcr.Documentation and citation updates:
NEWS.mdfile has been updated to document all major changes, including new connection logic, credential management, deprecations, and new features.CITATION.cfffile has been updated to reflect the new version, update the preferred citation, and revise software references to match the updated dependencies. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Miscellaneous improvements:
.gitattributesfile was added to standardize text handling and ignore diffs in test fixtures.These changes collectively modernize the
etnpackage, improve user experience, and ensure consistency between API and local database queries.References:
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]