-
Notifications
You must be signed in to change notification settings - Fork 503
Implement entry deletion feature #6955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@marinaej sorry, I had to rebase the base branch. Would you mind rebasing your PR? Probably the easiest would be something like this since you just have a single commit: and then check if there are any conflicts. |
402253c to
c36c67d
Compare
c36c67d to
1d21a31
Compare
7e3fa62 to
fcacf8a
Compare
|
I think we discussed it, but it probably got lost somewhere in translation. Could you maybe try to look into a fitting icon for unscheduling contributions? It seems like in this branch the contributions still have a delete icon. |
88f7a91 to
642a484
Compare
642a484 to
b43e82b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and well tested
* Implement entry deletion feature * fix delete function * Change icon for contributions * Add tooltip & button color * Fix actions request * Fix actions form ajobs comments * fix imports and variable names * remove redundant error handling * remove try catch
* Implement entry deletion feature * fix delete function * Change icon for contributions * Add tooltip & button color * Fix actions request * Fix actions form ajobs comments * fix imports and variable names * remove redundant error handling * remove try catch
* Implement entry deletion feature * fix delete function * Change icon for contributions * Add tooltip & button color * Fix actions request * Fix actions form ajobs comments * fix imports and variable names * remove redundant error handling * remove try catch
* Implement entry deletion feature * fix delete function * Change icon for contributions * Add tooltip & button color * Fix actions request * Fix actions form ajobs comments * fix imports and variable names * remove redundant error handling * remove try catch
* Implement entry deletion feature * fix delete function * Change icon for contributions * Add tooltip & button color * Fix actions request * Fix actions form ajobs comments * fix imports and variable names * remove redundant error handling * remove try catch
No description provided.