Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@marinaej
Copy link
Contributor

@marinaej marinaej commented Jul 3, 2025

No description provided.

@marinaej marinaej requested a review from AjobK July 3, 2025 14:52
@tomasr8
Copy link
Member

tomasr8 commented Jul 4, 2025

@marinaej sorry, I had to rebase the base branch. Would you mind rebasing your PR?

Probably the easiest would be something like this since you just have a single commit:

git reset --hard upstream/timetable
git cherry-pick 9bfbe25ab841915fbbc6ef359f701c917be613eb

and then check if there are any conflicts.

@marinaej marinaej force-pushed the timetable-entries-deletion branch from 402253c to c36c67d Compare July 4, 2025 08:28
@github-actions github-actions bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript deps labels Jul 4, 2025
@marinaej marinaej force-pushed the timetable-entries-deletion branch from c36c67d to 1d21a31 Compare July 4, 2025 12:10
@github-actions github-actions bot removed dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript deps labels Jul 4, 2025
@marinaej marinaej marked this pull request as draft July 4, 2025 12:11
@marinaej marinaej marked this pull request as ready for review July 4, 2025 12:20
@marinaej marinaej force-pushed the timetable-entries-deletion branch from 7e3fa62 to fcacf8a Compare July 4, 2025 12:36
@AjobK
Copy link
Member

AjobK commented Jul 4, 2025

I think we discussed it, but it probably got lost somewhere in translation. Could you maybe try to look into a fitting icon for unscheduling contributions? It seems like in this branch the contributions still have a delete icon.

@marinaej marinaej force-pushed the timetable-entries-deletion branch from 88f7a91 to 642a484 Compare July 10, 2025 14:52
@marinaej marinaej force-pushed the timetable-entries-deletion branch from 642a484 to b43e82b Compare July 14, 2025 13:33
Copy link
Member

@AjobK AjobK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and well tested

@AjobK AjobK merged commit 6cd0835 into indico:timetable Jul 14, 2025
7 checks passed
tomasr8 pushed a commit that referenced this pull request Aug 6, 2025
* Implement entry deletion feature

* fix delete function

* Change icon for contributions

* Add tooltip & button color

* Fix actions request

* Fix actions form ajobs comments

* fix imports and variable names

* remove redundant  error handling

* remove try catch
ThiefMaster pushed a commit that referenced this pull request Aug 25, 2025
* Implement entry deletion feature

* fix delete function

* Change icon for contributions

* Add tooltip & button color

* Fix actions request

* Fix actions form ajobs comments

* fix imports and variable names

* remove redundant  error handling

* remove try catch
ThiefMaster pushed a commit that referenced this pull request Oct 3, 2025
* Implement entry deletion feature

* fix delete function

* Change icon for contributions

* Add tooltip & button color

* Fix actions request

* Fix actions form ajobs comments

* fix imports and variable names

* remove redundant  error handling

* remove try catch
marinaej added a commit to marinaej/indico that referenced this pull request Oct 27, 2025
* Implement entry deletion feature

* fix delete function

* Change icon for contributions

* Add tooltip & button color

* Fix actions request

* Fix actions form ajobs comments

* fix imports and variable names

* remove redundant  error handling

* remove try catch
AjobK pushed a commit to AjobK/indico that referenced this pull request Oct 31, 2025
* Implement entry deletion feature

* fix delete function

* Change icon for contributions

* Add tooltip & button color

* Fix actions request

* Fix actions form ajobs comments

* fix imports and variable names

* remove redundant  error handling

* remove try catch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants