-
Notifications
You must be signed in to change notification settings - Fork 503
Fix double dialogue #6965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix double dialogue #6965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
reviewed
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have one question, otherwise looks good 👍
indico/modules/events/timetable/client/js/TimetableManageModal.tsx
Outdated
Show resolved
Hide resolved
tomasr8
reviewed
Jul 11, 2025
marinaej
approved these changes
Jul 11, 2025
tomasr8
pushed a commit
that referenced
this pull request
Aug 6, 2025
* make serializer more readable, add uniqueid, remove redundant code * separated uniqueID and objectID * rm unused id props * fix unscheduled ids and move modified legacy event serializer to new * fix child type being passed on edit
ThiefMaster
pushed a commit
that referenced
this pull request
Aug 25, 2025
* make serializer more readable, add uniqueid, remove redundant code * separated uniqueID and objectID * rm unused id props * fix unscheduled ids and move modified legacy event serializer to new * fix child type being passed on edit
ThiefMaster
pushed a commit
that referenced
this pull request
Oct 3, 2025
* make serializer more readable, add uniqueid, remove redundant code * separated uniqueID and objectID * rm unused id props * fix unscheduled ids and move modified legacy event serializer to new * fix child type being passed on edit
marinaej
pushed a commit
to marinaej/indico
that referenced
this pull request
Oct 27, 2025
* make serializer more readable, add uniqueid, remove redundant code * separated uniqueID and objectID * rm unused id props * fix unscheduled ids and move modified legacy event serializer to new * fix child type being passed on edit
AjobK
added a commit
to AjobK/indico
that referenced
this pull request
Oct 31, 2025
* make serializer more readable, add uniqueid, remove redundant code * separated uniqueID and objectID * rm unused id props * fix unscheduled ids and move modified legacy event serializer to new * fix child type being passed on edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents double dialogues from opening, or multiple entries being moved on drag. Needs to be tested properly by creating, reading, updating and dragging entries.
Miscellaneous: