Remove extra onclick and make prettier work #6983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasr8
commented
Jul 24, 2025
Comment on lines
-176
to
-179
| onClick={e => { | ||
| e.stopPropagation(); | ||
| dispatch(actions.selectEntry(id)); | ||
| }} |
There was a problem hiding this comment.
We already have this onClick here:
indico/indico/modules/events/timetable/client/js/Entry.tsx
Lines 39 to 44 in 55ace91
micsucmed
approved these changes
Jul 24, 2025
tomasr8
added a commit
that referenced
this pull request
Aug 6, 2025
* Make prettier happy & reformat code * Remove extra onclick
ThiefMaster
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Make prettier happy & reformat code * Remove extra onclick
ThiefMaster
pushed a commit
that referenced
this pull request
Oct 3, 2025
* Make prettier happy & reformat code * Remove extra onclick
marinaej
pushed a commit
to marinaej/indico
that referenced
this pull request
Oct 27, 2025
* Make prettier happy & reformat code * Remove extra onclick
AjobK
pushed a commit
to AjobK/indico
that referenced
this pull request
Oct 31, 2025
* Make prettier happy & reformat code * Remove extra onclick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prettier can't cope with
??inside TS files, but in this case we actually don't need it anyway.